add osgi metadata #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinst
reviewed
Mar 25, 2025
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> |
There was a problem hiding this comment.
The official guide seems to recommend a different approach:
Where does your approach come from, and what is the difference?
There was a problem hiding this comment.
I tried the standard approach and it was adding to many exports to the MANIFEST, feel free to try it out locally
There was a problem hiding this comment.
I meant these bits:
<supportedProjectTypes>
<supportedProjectType>jar</supportedProjectType>
<supportedProjectType>bundle</supportedProjectType>
</supportedProjectTypes>
...
<executions>
<execution>
<id>manifest</id>
<goals>
<goal>manifest</goal>
</goals>
<configuration>
<supportIncrementalBuild>true</supportIncrementalBuild>
</configuration>
</execution>
<execution>
<id>bundle</id>
<goals>
<goal>bundle</goal>
</goals>
</execution>
</executions>
I've pushed commits to the branch to follow the linked instructions above, and it still produces the same end result. Note that before, it looks like it built the jar file twice:
[INFO] --- jar:3.4.1:jar (default-jar) @ autolink ---
[INFO] Building jar: /Users/robinst/private/autolink-java/target/autolink-0.11.1-SNAPSHOT.jar
[INFO]
[INFO] --- bundle:5.1.9:bundle (bundle) @ autolink ---
[INFO] Building bundle: /Users/robinst/private/autolink-java/target/autolink-0.11.1-SNAPSHOT.jar
[INFO] Writing manifest: /Users/robinst/private/autolink-java/target/classes/META-INF/MANIFEST.MF
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
After:
[INFO] --- jar:3.4.1:jar (default-jar) @ autolink ---
[INFO] Building jar: /Users/robinst/private/autolink-java/target/autolink-0.11.1-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
There was a problem hiding this comment.
@zspitzer Let me know if that works for you, and happy to proceed with this.
Remove unnecessary supportedProjectTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
I've filed a PR for Commonmark which uses your nice library!
commonmark/commonmark-java#359
as I'm adding some Commmonmark extensions to Lucee
lucee/Lucee#2473
This PR adds the maven-bundle-plugin to the build to add the OSGI metadata required